Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Plugins endpoint was unauthenticated #14570

Merged
merged 1 commit into from
Mar 2, 2021
Merged

Bugfix: Plugins endpoint was unauthenticated #14570

merged 1 commit into from
Mar 2, 2021

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Mar 2, 2021

Before:

image
image

After:

User is redirected to login page

172.19.0.1 - - [02/Mar/2021:22:47:12 +0000] "GET /plugin HTTP/1.1" 302 311 "http://localhost:28080/home" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.192 Safari/537.36"
172.19.0.1 - - [02/Mar/2021:22:47:13 +0000] "GET /login/?next=http%3A%2F%2Flocalhost%3A28080%2Fplugin HTTP/1.1" 200 17422 "http://localhost:28080/home" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/88.0.4324.192 Safari/537.36"

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Mar 2, 2021
@kaxil kaxil added this to the Airflow 2.0.2 milestone Mar 2, 2021
@kaxil
Copy link
Member Author

kaxil commented Mar 2, 2021

cc @jhtimmins

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Mar 2, 2021
@github-actions
Copy link

github-actions bot commented Mar 2, 2021

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@kaxil kaxil merged commit 0a969db into apache:master Mar 2, 2021
@kaxil kaxil deleted the add0auth branch March 2, 2021 23:48
ashb pushed a commit that referenced this pull request Mar 19, 2021
@kaxil @ashb
Bugfix: Plugins endpoint was unauthenticated (#14570)
bfe57d3 
The plugins endpoint missed auth check

(cherry picked from commit 0a969db)
kaxil added a commit to astronomer/airflow that referenced this pull request Apr 1, 2021
@kaxil
Bugfix: Plugins endpoint was unauthenticated (apache#14570)
a87a20d 
The plugins endpoint missed auth check

(cherry picked from commit 0a969db)
(cherry picked from commit bfe57d3)
ashb pushed a commit that referenced this pull request Apr 15, 2021
@kaxil @ashb
Bugfix: Plugins endpoint was unauthenticated (#14570)
d6aa666 
The plugins endpoint missed auth check

(cherry picked from commit 0a969db)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashb ashb ashb approved these changes

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton

@potiuk potiuk Awaiting requested review from potiuk

@XD-DENG XD-DENG Awaiting requested review from XD-DENG

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy

Assignees
No one assigned
Labels
area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Milestone
Airflow 2.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@kaxil @ashb